Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added SDK multiple installations case #767

Merged
merged 5 commits into from
Apr 27, 2023
Merged

test: added SDK multiple installations case #767

merged 5 commits into from
Apr 27, 2023

Conversation

kirrg001
Copy link
Contributor

Proofs how to use the SDK with multiple installations for CJS & ESM.
Docs updates coming soon.

@kirrg001 kirrg001 requested a review from a team April 25, 2023 11:14
basti1302
basti1302 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@basti1302 basti1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the spurious console.logs which are still in there. 👍

.circleci/config.yml Outdated Show resolved Hide resolved
packages/collector/test/apps/agentStub.js Outdated Show resolved Hide resolved
packages/collector/test/apps/agentStub.js Outdated Show resolved Hide resolved
packages/core/src/tracing/cls.js Outdated Show resolved Hide resolved
@kirrg001 kirrg001 merged commit 019d969 into main Apr 27, 2023
@kirrg001 kirrg001 deleted the fix/sdk-k8s branch April 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basti1302 basti1302 basti1302 approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirrg001 @basti1302