fix(collector): keep EOL events open instead of recreating them #771
Conversation
| @@ -211,13 +214,13 @@ function sendEOLEvent() { | |||
| /** | |||
| * Sends an issue event to the agent when the Node.js version has reached end of life. | |||
| * It will work for non serverless environments where an agent is present. | |||
| * Also, currently the serverless-acceptor does not have support for events. | |||
| * (At the time of writing, serverless-acceptor does not have support for events.) | |||
There was a problem hiding this comment.
Suggestion: This sounds a bit like the support for serverless environments would be added here.
How about?
"At the time of writing, serverless-acceptor does not have support for events. See packages/serverless/src/backend_connector.js"
There was a problem hiding this comment.
Not sure I follow. This is talking about the Instana backend service serverless-acceptor. Support for ingesting events would need to be added there before we can add it in any of our modules. I'll try to make that more clear.
There was a problem hiding this comment.
Yes.
packages/serverless/src/backend_connector.js === backend service serverless-acceptor
There was a problem hiding this comment.
No.
https://github.ibm.com/instana/backend/blob/develop/serverless-acceptor/src/main/java/com/instana/serverless/ServerlessAcceptorApp.java === backend service serverless-acceptor
Anyway, I've changed the comment, so this should hopefully be a bit more clear now.
Suggestion: "fix(collector): keep EOL events open instead of recreating them" |
basti1302
force-pushed
the
fix/add-path-to-eol-event
branch
from
0c750af
to
7246e6c
Compare
basti1302
changed the title
|
For the record, I need to keep this open for a while to make some corresponding changes in the backend as well. I want to make the backend changes before merging this. |
Issue events that are sent to the Instana agent (and thereby indirectly to the Instana backend), are discarded when they expire according to their "duration" property. To keep them open for the entire lifetime of the entity (which makes sense for the EOL events we are dealing with here), we are ought to resend them before they expire in a heartbeat- like fashion. The backend requires a unique "path" attributes on these events to be able to group them together and to know that it is supposed to keep the already created issue open instead of opening a new issue. This commit adds that "path" attribute. Also: - change the duration of the event from 10 minutes to 6 hours - rename the misnamed AgentConnectionEvent type to just Event
basti1302
force-pushed
the
fix/add-path-to-eol-event
branch
from
7246e6c
to
cb3d70e
Compare
Issue events that are sent to the Instana agent (and thereby indirectly to the Instana backend), are discarded when they expire according to their "duration" property. To keep them open for the entire lifetime of the entity (which makes sense for the EOL events we are dealing with here), we are ought to resend them before they expire in a heartbeat- like fashion. The backend requires a unique "path" attributes on these events to be able to group them together and to know that it is supposed to keep the already created issue open instead of opening a new issue. This commit adds that "path" attribute.
Also: