ci: fixed coverage job #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
Jul 19, 2023
kirrg001
force-pushed
the
fix/coverage-job
branch
from
e8b04b6
to
e69d90d
Compare
[ci skip]
kirrg001
commented
Jul 26, 2023
| @@ -68,7 +68,7 @@ const DB2_TABLE_NAME_3 = process.env.DB2_TABLE_NAME_3 || 'table3'; | |||
| */ | |||
| let tries = 0; | |||
| const MAX_TRIES = 10; | |||
| const CONNECT_TIMEOUT_IN_MS = 500; | |||
| const CONNECT_TIMEOUT_IN_MS = 2000; | |||
There was a problem hiding this comment.
FYI I increased the timeouts. I am always running into a broken db2 test locally caused by longer connection issues to the db2 server.
basti1302
approved these changes
Jul 26, 2023
Comment on lines
+876
to
+880
| // Spans: | ||
| // 11 queries splitted from the file | ||
| // 4 fs operations on top (ours + from db2 internally fs-extra) | ||
| // https://github.com/ibmdb/node-ibm_db/blob/fb25937524d74d25917e9aa67fb4737971317986/lib/odbc.js#L916 | ||
| numberOfSpans: oTelIntegrationIsEnabled ? 15 : 11, | ||
| // If the Otel integration is disabled, we expect 11 spans. |
There was a problem hiding this comment.
question: If we no longer test for the exact number of spans, can we delete this comment entirely? I don't think it serves a purpose anymore.
| @@ -929,8 +923,7 @@ mochaSuiteFn('tracing/db2', function () { | |||
| .then(() => | |||
| testUtils.retry(() => | |||
| verifySpans(agentControls, controls, { | |||
| // 11 queries + fs calls | |||
| numberOfSpans: oTelIntegrationIsEnabled ? 16 : 11, | |||
| // 11 Instana spans + 5 Otel Spans | |||
There was a problem hiding this comment.
comment can probably be removed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs 132534
See conversation #825 (comment)