Gcr in process collector #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdimitra
force-pushed
the
gcr_in_process_collector
branch
from
69b58bb to
931fa2b
Compare
andrewslotin
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
I'm not entirely sure about the helper method signature and maybe this is a good chance for us to change it. The with_snapshot parameter only used in one helper, which suggests that snapshot collection is not a common behavior and probably should be extracted from the helper method.
andrewslotin
suggested changes
Oct 19, 2021
Co-authored-by: Andrey Slotin <andrey.slotin@instana.com>
Co-authored-by: Andrey Slotin <andrey.slotin@instana.com>
Co-authored-by: Andrey Slotin <andrey.slotin@instana.com>
Co-authored-by: Andrey Slotin <andrey.slotin@instana.com>
pdimitra
force-pushed
the
gcr_in_process_collector
branch
from
b9bdf2f to
3fe6df9
Compare
andrewslotin
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Google Cloud Run in process collector according to the technical documentation https://github.com/instana/technical-documentation/tree/a9a649ea2200e373766a537742083fc0a7db1b5e/tracing/in-process-collectors/google-cloud-run and following the existing architecture used for aws fargate