Skip to content

refactor(tests): Clean up old PEP-249 tests #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2023
Merged

refactor(tests): Clean up old PEP-249 tests #452

merged 5 commits into from
Sep 6, 2023

Conversation

Ferenc-
Copy link
Member

@Ferenc- Ferenc- commented Sep 1, 2023

  • Use the unittest module's assert in unit tests.
  • Drop legacy branching for unsupported 2.7
  • Eliminate unused variables
  • Remove superfluous initializations
  • Use unpack assignments

@Ferenc- Ferenc- requested review from pvital and GSVarsha September 1, 2023 15:21
pvital
pvital reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We should review all the tests and refactor them.

I have one comment only: it's not a big deal, but it's a best practice for readability.

pvital
pvital approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ferenc-
refactor(tests): Clean up old PEP-249 tests
b1cea7e 
* Use the `unittest` module's `assert` in unit tests.
* Drop legacy branching for unsupported 2.7
* Eliminate unused variables
* Remove superfluous initializations
* Use unpack assignments

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
GSVarsha reviewed Sep 4, 2023
View reviewed changes
@Ferenc- Ferenc- requested a review from pvital September 4, 2023 17:36
@Ferenc-
test: Fix mysqlclient to make database content predicatable
1979598 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- requested a review from GSVarsha September 5, 2023 08:52
@Ferenc-
test: Fix pymysql tests to make database content predicatable
501411f 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
GSVarsha approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me!

@Ferenc-
test: Fix psycopg2 tests to make database content predicatable
cf05392 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
test: Enable unicode tests in psycopg2
d884a3d 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- merged commit b951f7f into master Sep 6, 2023
@Ferenc- Ferenc- deleted the test-refactor branch September 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@pvital pvital Awaiting requested review from pvital

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferenc- @pvital @GSVarsha