Skip to content

Conversation

GSVarsha
Copy link
Contributor

FastAPI: capture responseHeadersOnEntrySpans

Signed-off-by: Varsha GS varsha.gs@ibm.com

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Dec 27, 2023
@GSVarsha GSVarsha requested review from pvital and Ferenc- December 27, 2023 17:39
Copy link
Member

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have requested a couple of small changes.

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment, It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- capture a list of headers

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested a review from Ferenc- January 2, 2024 12:22
Copy link
Member

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@GSVarsha GSVarsha merged commit 44ab8ff into master Jan 2, 2024
@GSVarsha GSVarsha deleted the fastapi-header-capture branch January 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants