-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Kafka FUP Phase I and Phase II #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e834b59
to
07cc254
Compare
@CagriYonca, please work on the #721 first, and after it is merged, we can finalize this one and the following one. |
d8d36f2
to
b79ab06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few requests.
I am missing some tests for the new functions or environment variables to be parsed, as the INSTANA_IGNORE_ENDPOINTS_PATH
.
634b521
to
b01bf7a
Compare
4bc4eb6
to
e1383d4
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Only two missing copyright headers and then you can merge it.
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Phase I - Changes:
configuration.yaml
file to filter specific services and methods now, as specified in the technical specification.configuration.yaml
file has the highest priority, usesend
for kafka-python andproduce
for confluent-kafka:Phase II - Changes: