This repository was archived by the owner on Sep 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Proposal for new Evaluation repo #79
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# New Repository Proposal: eval | ||
|
||
## Summary | ||
|
||
This document proposes a new repository under the `instructlab` GitHub organization: | ||
|
||
- `instructlab/eval` | ||
|
||
## Background | ||
|
||
The `instructlab/instructlab` repository currently includes no real implementation | ||
of Evaluation as described by the [LAB paper](https://arxiv.org/abs/2403.01081). The | ||
closest implementation currently in `instructlab/instructlab` via the `ilab test` command. | ||
|
||
`ilab test` as of this writing is only implemented for macOS with M-series chips. It uses | ||
alimaredia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
a JSON Lines file and a LoRA adapter to compare output of a given model before and after | ||
LoRA training with MLX, thus the macOS M-series dependency. | ||
|
||
We desire to build out a library for methods that satisfy the evaluation described in the | ||
paper, using more high-level evaluation schemes such as | ||
[Multi-turn Benchmark](https://arxiv.org/abs/2306.05685) for skills and | ||
[Massive Multitask Language Understanding](https://arxiv.org/abs/2009.03300) (MMLU) for | ||
knowledge. We propose a new repository to house this code that publishes a new Python | ||
library called `instructlab-eval`. The reasoning for a new repository and library includes: | ||
|
||
- We expect multiple consumers of this code. The `ilab` CLI is one, but we also envision | ||
building a REST API around it to help support scaling out this functionality on a cluster. | ||
- We expect there is broader community interest in an open-source library and service for | ||
evaluation. We envision this library could support other evaluation techniques over time. | ||
- We also realize that much of model evaluation is generally useful outside the context of | ||
InstructLab. Other libraries may emerge in the broader ecosystem that handle parts of what | ||
we need, while this library will always remain to handle the InstructLab-specific details | ||
of how evaluation works in our workflow. | ||
|
||
## Maintainers | ||
|
||
The initial team of maintainers for this repository will be a copy of the | ||
`Backend Maintainers` GitHub team. | ||
|
||
## Alternatives Considered | ||
|
||
### Add to `instructlab/instructlab` | ||
|
||
We could add this code to the existing `instructlab/instructlab` repository. | ||
|
||
The primary argument against this approach is that we expect the scope of an | ||
`instructlab-eval` library to expand beyond the scope of what would be run by the | ||
`ilab` CLI. We instead envision a different community of contributors organizing | ||
around Evaluation specifically. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.