Add UX review templates for notebook submissions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinXHale
force-pushed
the
add-ux-review-template
branch
from
e55c736 to
00b55fc
Compare
|
This looks great to me! The only change I would make is I'd only have there be one file, and that file be called: Since we'd just want to have these UX reviews as a comment to PRs, and have it live at the root of the repo right now, not in the |
JustinXHale
force-pushed
the
add-ux-review-template
branch
6 times, most recently
from
237efa5 to
97bccea
Compare
added 3 commits
April 30, 2025 13:37
Signed-off-by: justinxhale <justinxhale@gmail.com>
Signed-off-by: justinxhale <justinxhale@gmail.com>
Signed-off-by: justinxhale <justinxhale@gmail.com>
JustinXHale
force-pushed
the
add-ux-review-template
branch
from
74c4312 to
c7d6eda
Compare
alimaredia
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a markdown and Jupyter version of the UX review template. Intended for contributors and reviewers to standardize UX alignment for all notebooks.