Skip to content

Commit d7372fe

Browse files
author
Chris Hart
committed
fix(ui-range-input): patch CSS for legacy Edge
fixes: INSTUI-2614 Test plan: - Test RangeInput in both Chromium Edge and legacy Edge (any version prior to 79). You should see the following: https://share.getcloudapp.com/ApujDbN9 - Test RangeInput in other browsers to make sure there are no regressions. Change-Id: I773da29855c57e37ad873e848afb018257e189da Reviewed-on: https://gerrit.instructure.com/c/instructure-ui/+/236671 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Steve Jensen <sejensen@instructure.com> QA-Review: Daniel Sasaki <dsasaki@instructure.com> Product-Review: Chris Hart <chart@instructure.com> Visual-Regression-Test: Chris Hart <chart@instructure.com>
1 parent e73c85c commit d7372fe

File tree

1 file changed

+27
-7
lines changed

1 file changed

+27
-7
lines changed

packages/ui-range-input/src/RangeInput/styles.css

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,26 +71,46 @@
7171
height: calc(var(--handleSize) / 2);
7272
}
7373

74+
/*
75+
TODO: delete -ms- selectors once support for legacy Edge is
76+
phased out. Chromium Edge ignores them.
77+
*/
78+
79+
/* stylelint-disable property-no-vendor-prefix, color-no-hex */
7480
&::-ms-track {
75-
background: transparent;
76-
border-width: var(--handleSize) 0;
81+
border-width: 1rem 0;
7782
}
7883

7984
&::-ms-fill-upper,
8085
&::-ms-fill-lower {
81-
border-width: var(--handleSize) 0;
82-
border-radius: calc(var(--handleSize) / 2);
83-
background: var(--trackBackground);
86+
border-width: 1.5rem 0;
87+
border-radius: 0.75rem;
88+
background: #2d3b45;
8489
}
8590

8691
&::-ms-tooltip {
8792
display: none;
8893
}
94+
95+
&::-ms-thumb {
96+
-webkit-appearance: none;
97+
width: 1.75rem;
98+
height: 1.75rem;
99+
box-sizing: border-box;
100+
border-radius: 100%;
101+
background: #fff;
102+
border: 0.25rem solid #2d3b45;
103+
margin-top: 0.0625rem;
104+
}
89105
}
106+
/* stylelint-enable property-no-vendor-prefix, color-no-hex */
90107

91-
/* patch broken MSEdge keyboard focus styles in 16 and up */
108+
/*
109+
TODO: delete selector below and remove isEdge util once legacy Edge support is
110+
phased out.
111+
*/
92112
.edge16Up .input:focus {
93-
outline: 0.0625rem solid var(--handleBackground);
113+
outline: 0.125rem solid var(--handleBackground);
94114
}
95115

96116
.value {

0 commit comments

Comments
 (0)