Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-radio-input): only radio button and label are clickable #1671

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(ui-radio-input): only radio button and label are clickable #1671

merged 1 commit into from
Sep 10, 2024

Conversation

joyenjoyer
Copy link
Contributor

Closes: INSTUI-4197

Test plan

Go through all of the RadioInput/RadioInputGroup examples in the docs app:

  • Check whether the design is not broken
  • click events should be registered if you click on the radio group icon or label. If you click on the remaining area of the radio input, click should not be registered.

@joyenjoyer joyenjoyer self-assigned this Sep 5, 2024
@joyenjoyer joyenjoyer marked this pull request as draft September 5, 2024 14:53
@joyenjoyer
Copy link
Contributor Author

joyenjoyer commented Sep 5, 2024 •
edited
Loading

Ready to be reviewed.

@joyenjoyer joyenjoyer force-pushed the INSTUI-4197-only-the-graphic-text-part-should-be-clickable-in-radio-buttons-toggles-and-checkboxes branch from cf7942a to 8cf6ea6 Compare September 5, 2024 14:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-10 12:00 UTC

@joyenjoyer joyenjoyer force-pushed the INSTUI-4197-only-the-graphic-text-part-should-be-clickable-in-radio-buttons-toggles-and-checkboxes branch 2 times, most recently from a72e407 to d3c77f6 Compare September 6, 2024 13:21
@joyenjoyer joyenjoyer force-pushed the INSTUI-4197-only-the-graphic-text-part-should-be-clickable-in-radio-buttons-toggles-and-checkboxes branch from d3c77f6 to 13613a5 Compare September 6, 2024 13:24
@joyenjoyer joyenjoyer marked this pull request as ready for review September 6, 2024 13:25
@joyenjoyer joyenjoyer merged commit 77b2a7d into master Sep 10, 2024
11 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-4197-only-the-graphic-text-part-should-be-clickable-in-radio-buttons-toggles-and-checkboxes branch September 10, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToMESSKa ToMESSKa ToMESSKa approved these changes

@git-nandor git-nandor git-nandor approved these changes

@matyasf matyasf Awaiting requested review from matyasf

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyenjoyer @git-nandor @ToMESSKa