Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of native PayPal Express checkout (button) #10

Open
sfritzsche opened this issue Feb 3, 2022 · 0 comments
Open

Handling of native PayPal Express checkout (button) #10

sfritzsche opened this issue Feb 3, 2022 · 0 comments
Assignees

Comments

@sfritzsche
Copy link

We're talking about the PayPal Express process, which can be launched from the product detail page or the mini shopping cart. (/paypal/express/start/button/1/)

Problem 1: In the current state, the mocked shipping address is transferred to PayPal. (@see vendor/magento/module-paypal/Model/Express/Checkout.php:551)

Solution to problem 1: Extend your configuration (integernet/shipping_preselection/mock_unset_urls) with the entry "paypal_express_start" to trigger an "isAddressResetRequest" for this FullActionName. This will then delete the mocked shipping address.

Problem 2: Now when we start the PayPalExpress checkout, the current quote is saved again. @see vendor/magento/module-paypal/Model/Express/Checkout.php:503

This finally fails at the following location:

vendor/magento/module-quote/Model/ShippingMethodManagement.php:222

The reason is that when you do an "isAddressResetRequest" you only delete the shipping address but do not reset the shipping method.

My understanding is that this should happen combined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants