Skip to content

7499/indexer #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 12, 2018
Merged

7499/indexer #15

merged 6 commits into from
Jan 12, 2018

Conversation

schmengler
Copy link
Contributor

This PR contains

  • new indexer method reindexSlice() as nicer interface to reindex slices. The old way with additional parameters to reindex() still works, but has been deprecated
  • an interface for the indexer. This is supposed to be used by other indexers (category indexer, cms indexer) as well to make it easier to use various indexers from a single place, like a CLI command. Public methods of the indexer that were only used by itself are not part of the interface and marked as deprecated in the class.
  • a progress update dispatcher for the indexer. Clients can register progress handlers who receive updates about the indexer progress, which can be used to log or display the status during indexing
  • PHPUnit requirement changed from 4 to 5 (4 to 6 requires too much change at once, 5 to 6 comes next)

These make sense for sliced reindex of shadow core, as in the CLI command with --useswapcore
@avstudnitz avstudnitz merged commit 4fbca34 into master Jan 12, 2018
@avstudnitz avstudnitz deleted the 7499/indexer branch January 12, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants