-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGDAPI - 4544 Postgres Create #576
MGDAPI - 4544 Postgres Create #576
Conversation
00b5a17
to
a93b622
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## mgdapi-3425-gcp #576 +/- ##
===================================================
+ Coverage 70.47% 70.89% +0.41%
===================================================
Files 46 46
Lines 6012 6157 +145
===================================================
+ Hits 4237 4365 +128
- Misses 1405 1414 +9
- Partials 370 378 +8
|
81ba67e
to
122b784
Compare
> > Co-authored-by: Adam Cattermole acatterm@redhat.com Co-authored-by Fiona Waters fwaters@redhat.com
122b784
to
95fac97
Compare
… more test cases to unit tests. > Co-authored-by Laura Fitzgerald lfitzger@redhat.com Co-authored-by Fiona Waters fwaters@redhat.com
95fac97
to
f3fa2c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully created a Postgres instance using the provided instructions.
I'm satisfied with the work done and I could connect to the Postgres instance using Cloud SQL Auth proxy and data from the Postgres secret:
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cecobask, MStokluska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Overview
MGDAPI-4544
Adding functionality to create a Postgres instance in GCP.
Verification
Provision a GCP cluster
Create a Postgres Instance
make cluster/prepare
PROVIDER=gcp make cluster/seed/postgres
make run
gcloud sql instances list
Delete the Postgres CR and GCP Postgres instance.
oc delete postgres example-postgres -n cloud-resource-operator