Skip to content

🎨 Change format to use fmtlib compile-time formatting #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

🎨 Change format to use fmtlib compile-time formatting #338

merged 1 commit into from
Aug 14, 2023

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Aug 14, 2023

Closes #257
Addresses #105

@lukevalenty
Copy link
Contributor

I'm going to need to take a close look at this on Monday. 🤩

@lukevalenty lukevalenty enabled auto-merge August 14, 2023 16:22
@lukevalenty lukevalenty disabled auto-merge August 14, 2023 16:22
@lukevalenty lukevalenty enabled auto-merge August 14, 2023 16:22
lukevalenty
lukevalenty approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would be nice to be able to treat string_constant and lazy_string_format the same way.

@lukevalenty lukevalenty merged commit 7c01e60 into intel:main Aug 14, 2023
@elbeno elbeno deleted the formatting branch October 11, 2023 22:20
@antonysigma antonysigma mentioned this pull request Feb 10, 2025
Open
@antonysigma antonysigma mentioned this pull request Apr 17, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevalenty lukevalenty lukevalenty approved these changes

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 formatting a string with compile-time arguments should always return a string_constant and not lazy_string_format
2 participants
@elbeno @lukevalenty