msg::callback::handle args determined by caller #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcaisse-intel
force-pushed
the
msg-handler
branch
from
8b5015f to
002a756
Compare
|
If we remove |
I believe so. I'll update the PR. |
mjcaisse-intel
force-pushed
the
msg-handler
branch
from
002a756 to
4ce415a
Compare
mjcaisse-intel
force-pushed
the
msg-handler
branch
from
4ce415a to
176f329
Compare
rubyliuintelcom
approved these changes
Jul 16, 2024
lukevalenty
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of message callback handler construction would deduce the
ExtraArgsfrom the callable passed in by the user when forming the callback. This is no longer the case which means that the signature ofmsg::callback::handledoes not match the signature of the containedcallable.This PR works around the issue; however, the real question is, "do we want to deduce the
ExtraArgsfrom the user's handler? Deducing has some real problems because the handler is not always concrete (e.g. a generic lambda). I think the PR solution is probably the correct route.