✨ Add message packing #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Message definitions can't easily be combined, especially when the locations of fields are fixed in definitions and it would be useful to pack two or more messages together. - See issue intel#653 Solution: - Add primitives for combining messages: - `shifted_by` on fields and messages to increment their location(s) - `msg::combine` to naively combine multiple messages together - `msg::pack` to concatenate messages according to desired alignment Notes: - `at` has been simplified
elbeno
force-pushed
the
combine-messages
branch
from
be43067 to
f82e5bb
Compare
lukevalenty
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
shifted_byon fields and messages to increment their location(s)msg::combineto naively combine multiple messages togethermsg::packto concatenate messages according to desired alignmentNotes:
athas been simplified