✨ Add CIB_WITH_LOG_ENV
#681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `CIB_LOG_ENV` defines a current logging environment, but it doesn't introduce a scope, so defining more than one in a scope is ill-formed. - Defining a logging environment for just one log line is verbose. - The logging macros themselves should not get overloaded with environment gunk, even if there were a suitable way to do so. Solution: - Add `CIB_WITH_LOG_ENV` that allows defining a logging environment scope easily.
lukevalenty
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
CIB_LOG_ENVdefines a current logging environment, but it doesn't introduce a scope, so defining more than one in a scope is ill-formed.Solution:
CIB_WITH_LOG_ENVthat allows defining a logging environment scope easily.