Skip to content

🐛 Fix possible ambiguity in tuple indexing #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

🐛 Fix possible ambiguity in tuple indexing #139

merged 1 commit into from
Sep 23, 2024

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Sep 19, 2024

Problem:

  • Putting class types into a tuple uses inheritance.
  • A tuple inside a tuple may produce the same base type more than once in the tree, leading to indexing ambiguity.

Solution:

  • Use composition only, not inheritance, for tuple elements.

@elbeno
🐛 Fix possible ambiguity in tuple indexing
3be1ad9 
Problem:
- Putting class types into a tuple uses inheritance.
- A tuple inside a tuple may produce the same base type more than once in the
  tree, leading to indexing ambiguity.

Solution:
- Use composition only, not inheritance, for tuple elements.
@lukevalenty lukevalenty merged commit 66f25a0 into intel:main Sep 23, 2024
31 checks passed
@elbeno elbeno deleted the unambiguous-tuple branch October 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukevalenty lukevalenty lukevalenty approved these changes

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elbeno @lukevalenty