Skip to content

🐛 Allow UDL to work with digit separators #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

🐛 Allow UDL to work with digit separators #170

merged 2 commits into from
Nov 8, 2024

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Nov 6, 2024

Problem:

  • The _c UDL doesn't deal with digit separators.

Solution:

  • Fix it.

@elbeno
🐛 Allow UDL to work with digit separators
f2d7d7d 
Problem:
- The `_c` UDL doesn't deal with digit separators.

Solution:
- Fix it.
lukevalenty
lukevalenty approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an issue with octal being parsed as decimal, which result in incorrect values. that issue was already in the code, so i'm fine if you want to fix it in a seperate PR.

@elbeno elbeno requested a review from lukevalenty November 8, 2024 16:00
lukevalenty
lukevalenty approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 😎

@bdeane-intel bdeane-intel merged commit 4329991 into intel:main Nov 8, 2024
32 checks passed
@elbeno elbeno deleted the fix-udl-digitsep branch November 8, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukevalenty lukevalenty lukevalenty approved these changes

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elbeno @lukevalenty @bdeane-intel