✨ Add reason to = delete where available
#256
Merged
+75
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
delete-has-a-reason
branch
from
1c4b584 to
93d5415
Compare
Problem:
- C++26 adds `= delete("should have a reason")` with https://wg21.link/P2573.
This is implemented by clang-19 onwards, and also backported by clang to
earlier language versions, so we can take advantage of it compiling with
`-std=c++20`.
Solution:
- Add `STDX_DELETED` macro to provide a reason where possible.
Note:
- This is also implemented by GCC 15 and later, but GCC does not backport the
feature to language versions before C++26.
elbeno
force-pushed
the
delete-has-a-reason
branch
from
93d5415 to
2e619de
Compare
lukevalenty
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
= delete("should have a reason")with https://wg21.link/P2573. This is implemented by clang-19 onwards, and also backported by clang to earlier language versions, so we can take advantage of it compiling with-std=c++20.Solution:
STDX_DELETEDmacro to provide a reason where possible.Note: