Missing database upgrade code?

[terriko]

[12:30:03] INFO     cve_bin_tool - Unable to insert data for NVD - table  cvedb.py:397
                    cve_range has no column named data_source

We may need some code to properly upgrade the schema of the cve_range table in the case where you're doing incremental upgrades and haven't done a -u now since that code was added. Pinging @anthonyharrison just so he knows it's happening.

[anthonyharrison]

@terriko I haven't added any code to check for the database upgrade to the cve_range table - only the cve_severity table is checked (maybe we should be checking all tables?). I think the simplest upgrade might be to just delete the database if we get a database error as this will force a rebuild of the database. We probably need a simple _delete_database() routine adding to cve_db.py whcih can do this and then terminate the script.

Long term, I think it would be good if we could have all of the database codie (select statements etc) in one place so we can have consistent error handling.

[terriko]

Yeah, I'm wondering if maybe it's time to consider using a db library that could handle upgrading schemas, but that's out of scope for today's problem. :)

I think maybe for today just adding a check in init_database() similar to the cve_severity one would probably do the trick?

[terriko]

Okay, I've got a pretty basic update where I extend the schema check in cvedb.py. I tossed it into #2432 even though that's a bit unrelated because there's no way to get one to pass in CI without the other at the moment.
https://github.com/intel/cve-bin-tool/pull/2432/files

[terriko]

@anthonyharrison okay, #2432 solved the problem for me locally (the database upgrade, everything is fine) but I think I need to merge it so that we can then re-run the cache update that failed last night and is currently leaving us with broken everything. If you've got a bit of time to do code review that would be much appreciated! I'm going to go for lunch but I'll probably merge it (with our without review) after I'm done so that I can hopefully update the cache and continue resolving issues in main.