test: scanner: Cache archives #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnandersen777
force-pushed
the
less_downloading
branch
from
a60fc5c to
6e973d6
Compare
|
This PR has all the cached files added to the repo. https://github.com/pdxjohnny/cve-bin-tool/actions/runs/502227021 is a CI run where GitHub Actions should run |
…heckers This way we can override it if we don't want to run the checkers. Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
For test_version_in_package() where we test against a lot of URLs, we consistently have issues downloading those URLs. Instead of adding all the files we are downloading to test the scanner on to the git repo, we've run the recursive extraction and strings and created condensed versions of the URLs contents. We will now be able to add these condensed files to our Git repo to increase speed and stability of testing. Users adding new tests should commit the added files that appear in test/condensed-downloads/. Since that is the condensed version of the URL for the test they've added. Add test/downloads/ to the .gitignore Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Signed-off-by: John Andersen <john.s.andersen@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 87.25% 86.50% -0.76%
==========================================
Files 169 169
Lines 2895 2934 +39
Branches 321 328 +7
==========================================
+ Hits 2526 2538 +12
- Misses 290 315 +25
- Partials 79 81 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes creates condensed versions of the archives referenced by the files
in
test/test_data/. We addmake_condensed_from_download()withintest_scanner.pywhich takes an archive URL and runs strings on everythingidentified as a binary within the archive. We create fake binaries just as we do
with the mapping data tests and add those to an archive which we store within
our git repo at
test/condensed-downloads/Commits:
version scanner: Create separate method,
run_checkers()for running checkerstest: scanner: Cache downloads and condense them
For
test_version_in_package()where we test against a lot of URLs, weconsistently have issues downloading those URLs. Instead of adding all
the files we are downloading to test the scanner on to the git repo,
we've run the recursive extraction and strings and created condensed
versions of the URLs contents.
We will now be able to add these condensed files to our Git repo to
increase speed and stability of testing.
Users adding new tests should commit the added files that appear in
test/condensed-downloads/. Since that is the condensed version of the
URL for the test they've added.
Add test/downloads/ to the .gitignore
test: condensed downloads: Add all the archives to the cache folder