Skip to content

Conversation

b31ngd3v
Copy link
Contributor

closes #1993

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #2009 (cc111da) into main (b6632d6) will decrease coverage by 2.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   85.04%   82.94%   -2.10%     
==========================================
  Files         335      335              
  Lines        7583     7583              
  Branches      989      989              
==========================================
- Hits         6449     6290     -159     
- Misses        861     1035     +174     
+ Partials      273      258      -15     
Flag Coverage Δ
longtests 78.00% <100.00%> (-0.08%) ⬇️
win-longtests 81.82% <100.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/helper_script.py 85.65% <100.00%> (ø)
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 36.75% <0.00%> (-18.92%) ⬇️
test/test_json.py 73.33% <0.00%> (-16.67%) ⬇️
cve_bin_tool/cvedb.py 43.14% <0.00%> (-10.37%) ⬇️
cve_bin_tool/cli.py 71.27% <0.00%> (+0.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@terriko
Copy link
Contributor

terriko commented Oct 4, 2022

BTW, unless I've counted wrong, this should be your 4th contribution merged in October, so if you're doing hacktoberfest you should be done! Please leave any other stuff tagged as "hacktoberfest" for new participants looking for their first 4 merged pull requests, but you're always welcome to work on anything else you want to do!

@terriko terriko merged commit e1b47ac into intel:main Oct 4, 2022
@b31ngd3v b31ngd3v deleted the 1993 branch November 17, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use pathlib in helper_script.py
3 participants