Skip to content

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1981

XDRAGON2002 and others added 30 commits December 29, 2021 17:51
@codecov-commenter
Copy link

Codecov Report

Merging #2016 (bab7bfa) into main (b6632d6) will decrease coverage by 7.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
- Coverage   85.04%   78.00%   -7.05%     
==========================================
  Files         335      335              
  Lines        7583     7583              
  Branches      989      989              
==========================================
- Hits         6449     5915     -534     
- Misses        861     1407     +546     
+ Partials      273      261      -12     
Flag Coverage Δ
longtests 78.00% <100.00%> (-0.08%) ⬇️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/version_signature.py 74.50% <100.00%> (ø)
test/test_requirements.py 0.00% <0.00%> (-89.88%) ⬇️
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
test/test_source_nvd.py 60.71% <0.00%> (-39.29%) ⬇️
test/test_scanner.py 60.13% <0.00%> (-34.27%) ⬇️
test/test_source_osv.py 68.85% <0.00%> (-31.15%) ⬇️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 29.18% <0.00%> (-26.49%) ⬇️
test/test_source_gad.py 73.68% <0.00%> (-24.57%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@terriko terriko merged commit bacf0d9 into intel:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: use pathlib in version_signature.py
3 participants