Skip to content

Conversation

FReeshabh
Copy link
Contributor

modified:   checkers/__init__.py
new file:   checkers/bluez.py

	modified:   checkers/__init__.py
	new file:   checkers/bluez.py
@terriko
Copy link
Contributor

terriko commented Oct 18, 2019

Thank you! This is looking pretty good, but I currently get the following error when I run it:

"ValueError: Docstring of 'bluez' checker does not define a vendor package pair"

It looks like you're missing the VPkg definition in the docstring. It should look like this:

VPkg: bluez, bluez

There's some instructions about it here:
https://github.com/intel/cve-bin-tool/blob/master/cve_bin_tool/checkers/README.md


# def get_version(lines, filename):
def get_version(lines, filename):
"""Bluetoothctl will work for Version 5.0+"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to include the
Vpkg: bluez, bluez

string in the bottom of this docstring so that the checker can do the magic of associating it with the database entries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Vpkg string at the bottom of the doc string. I might have made an unneeded comment, so you might need to squash the commits. Thanks for the guidance!

@terriko
Copy link
Contributor

terriko commented Oct 28, 2019

Sorry about the delay in getting this merged; I've been travelling. I'm just trying to get my remote setup working properly to run the tests since travis isn't behaving, but I'm expecting to get this merged today.

@terriko terriko merged commit af33b7c into intel:master Oct 28, 2019
@terriko
Copy link
Contributor

terriko commented Oct 28, 2019

Got it working; thanks! I'll file a bug so we don't forget to add a test for bluez, too.

This was referenced Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants