Skip to content

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Mar 2, 2023

part of #2577

This is, incidentally, a pro for the "make a bunch of json files that can be re-loaded" theory, since they could and would be chopped into more manageable year/month chunks.

Originally posted by @terriko in #2577 (comment)

Export Database as bunch of JSON files chopped up by years

image

Import Database from bunch of JSON files chopped up by years

image

Directory structure of exported data

image

@terriko
Copy link
Contributor

terriko commented Mar 2, 2023

I'll need to come back and code review this more carefully when I've got more time, but I wanted to say that this looks like the right direction and I'm very excited about it! 👍 👍 👍

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #2774 (7e66e77) into main (fbe3cac) will decrease coverage by 0.81%.
The diff coverage is 15.87%.

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   82.62%   81.81%   -0.81%     
==========================================
  Files         646      646              
  Lines       10018    10139     +121     
  Branches     1334     1363      +29     
==========================================
+ Hits         8277     8295      +18     
- Misses       1403     1495      +92     
- Partials      338      349      +11     
Flag Coverage Δ
longtests 80.74% <15.87%> (+3.72%) ⬆️
win-longtests 79.13% <15.87%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 56.33% <15.25%> (-15.40%) ⬇️
cve_bin_tool/cli.py 67.08% <25.00%> (-0.76%) ⬇️
cve_bin_tool/data_sources/gad_source.py 70.00% <0.00%> (-16.25%) ⬇️
cve_bin_tool/data_sources/nvd_source.py 56.04% <0.00%> (-0.81%) ⬇️
cve_bin_tool/output_engine/console.py 97.60% <0.00%> (+1.59%) ⬆️
test/test_cli.py 86.23% <0.00%> (+2.17%) ⬆️
cve_bin_tool/data_sources/osv_source.py 81.77% <0.00%> (+2.33%) ⬆️
cve_bin_tool/data_sources/redhat_source.py 66.22% <0.00%> (+3.31%) ⬆️
cve_bin_tool/output_engine/pdfbuilder.py 91.07% <0.00%> (+7.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to get back to this! It's looking really good. I'm going to merge it then probably take it to some folk who were considering helping us with a mirror system -- they may have some more feedback once they try it out, but I think it'll be easier to do once it's merged. Thank you so much for working on this!

@terriko terriko merged commit 63543d0 into intel:main Mar 10, 2023
@b31ngd3v b31ngd3v deleted the 2577_1 branch March 10, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants