Skip to content

Conversation

stvml
Copy link
Contributor

@stvml stvml commented Apr 26, 2023

The deb extractor within extractor.py now handles zstd-compressed archive contents, which is supported in newer dpkg releases.

fixes: #2942

The deb extractor within `extractor.py` now handles zstd-compressed
archive contents, which is supported in newer dpkg releases.

fixes: #2942
@codecov-commenter
Copy link

Codecov Report

Merging #2946 (ee2c729) into main (95a48fd) will increase coverage by 2.98%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
+ Coverage   79.49%   82.48%   +2.98%     
==========================================
  Files         670      672       +2     
  Lines       10485    10628     +143     
  Branches     1218     1435     +217     
==========================================
+ Hits         8335     8766     +431     
+ Misses       1760     1493     -267     
+ Partials      390      369      -21     
Flag Coverage Δ
longtests 75.98% <50.00%> (?)
win-longtests 80.21% <50.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 79.22% <50.00%> (+8.42%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Since I think this probably brings us inline with what users would expect normal "supports deb packages" behaviour to be I'm not going to ask you to add it to the docs, but I will open up a separate issue for a test.

@terriko terriko merged commit 2a1f881 into intel:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Extractor fails when deb archive contains tar.zst files
3 participants