Skip to content

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented May 8, 2023

fixes #2977 #2969

this issue occurred because of this:

from wayback machine ->
image

now ->
image

@codecov-commenter
Copy link

Codecov Report

Merging #2984 (fd45d10) into main (1b4e78f) will increase coverage by 0.35%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
+ Coverage   76.08%   76.44%   +0.35%     
==========================================
  Files         674      674              
  Lines       10673    10626      -47     
  Branches     1439     1426      -13     
==========================================
+ Hits         8121     8123       +2     
+ Misses       2226     2179      -47     
+ Partials      326      324       -2     
Flag Coverage Δ
longtests 76.44% <33.33%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/data_sources/curl_source.py 59.18% <33.33%> (+22.72%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging this one! I wonder if we need to make it fail more gracefully and with more clear text or if the issue was GAD at the same time last week.

@terriko terriko merged commit 499e0a0 into intel:main May 9, 2023
@b31ngd3v b31ngd3v deleted the fix_curl_datasource branch May 10, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get KeyError: 'cve' during NVD database download
3 participants