build: move to PEP 621 project #5379
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all project metadata was moved to pyproject.toml
Molkree
force-pushed
the
build/pyproject-toml-config
branch
3 times, most recently
from
38049df to
fbc4a02
Compare
Black config was not changed but we have different result compared to main branch this is because Black determines supported Python versions from pyproject.toml in absence of the `requires-python` section it is determined on the per file basis now that we have full-fledged pyproject.toml Black follows our config more strictly
Molkree
force-pushed
the
build/pyproject-toml-config
branch
from
fbc4a02 to
da38201
Compare
now that dev-dependencies were moved to pyproject.toml our old script would no longer work dropping this means that there might be some short period of time when pre-commit config will be ahead of pyproject.toml but this shouldn't be a big deal we could rewrite it to update new location but because we now have Dependabot enabled pyproject.toml should stay updated through Dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1595
TODO list for this PR
test/test_requirements.py, it expectsrequirements.txtto be presentrequirements.csv