Skip to content

Update the runtime to remove old glibc exceptions that are no longer needed after the new compiler update #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Update the runtime to remove old glibc exceptions that are no longer needed after the new compiler update #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e0a4e
Use new strings
mendell27 Dec 3, 2024
20b0d72
Merge branch 'intel:main' into intel_llvm
mendell27 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,6 @@ set_target_properties(acl_objs PROPERTIES
target_compile_features(acl_objs PRIVATE cxx_std_11)
# These compile_definitions need to be public, since we're building an OBJECT library (?)
target_compile_definitions(acl_objs PUBLIC
# Revert to old pre-C++11 ABI for std::string and std::list in libstdc++.
# This is needed for ABI compatibility with the Intel® FPGA Add-On for
# oneAPI Base Toolkit, particularly the simulation flow, which accesses
# the internal runtime API that exposes C++ structures and functions.
# https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html
_GLIBCXX_USE_CXX11_ABI=0
ACL_SUPPORT_DOUBLE=1
ACL_HAS_STDLIB_STDIO
CL_USE_DEPRECATED_OPENCL_1_0_APIS=1
Expand Down
1 change: 0 additions & 1 deletion fuzz_testing/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ add_executable(acl_fuzz_test
set_target_properties(acl_fuzz_test PROPERTIES CXX_EXTENSIONS OFF)
target_compile_features(acl_fuzz_test PRIVATE cxx_std_11)
target_compile_definitions(acl_fuzz_test PRIVATE
_GLIBCXX_USE_CXX11_ABI=0
"ACL_TARGET_BIT=${ACL_TARGET_BIT}"
CL_USE_DEPRECATED_OPENCL_1_0_APIS=1
CL_USE_DEPRECATED_OPENCL_1_1_APIS=1
Expand Down
1 change: 0 additions & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ add_executable(acl_test
set_target_properties(acl_test PROPERTIES CXX_EXTENSIONS OFF)
target_compile_features(acl_test PRIVATE cxx_std_11)
target_compile_definitions(acl_test PRIVATE
_GLIBCXX_USE_CXX11_ABI=0
"ACL_TARGET_BIT=${ACL_TARGET_BIT}"
CL_USE_DEPRECATED_OPENCL_1_0_APIS=1
CL_USE_DEPRECATED_OPENCL_1_1_APIS=1
Expand Down
Loading