Copy DecomposeAggregatedOps pass from tpp-mlir #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui1995
requested review from
WangJialei-A,
Menooker,
zhczhong,
ZhennanQin and
kurapov-peter
|
We're waiting the upstream solution from: llvm/llvm-project#97582. @kurapov-peter would you please provide some insights? |
Oh, I did not notice this PR on llvm, @WangJialei-A found this issue when writing linalg single op validation, I think if we can get the upstream PR merged before our validation, then we can close this PR and use upstream. |
|
Unfortunately it won't land in the nearest future. The decision is to create a generic decomposition mechanism (that I'm working on now). I could put a similar implementation into GC if we need it. Do we? |
xurui1995
force-pushed
the
xurui/decompose_softmax
branch
from
3c72835 to
c639459
Compare
kurapov-peter
approved these changes
Aug 6, 2024
|
Please rebase. |
ZhennanQin
approved these changes
Aug 23, 2024
xurui1995
force-pushed
the
xurui/decompose_softmax
branch
from
71716fd to
ed004d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from tpp-mlir project
The current MLIR repo does not offer an easy-to-use pass for decomposing
linalg.softmax, andtpp-mlirprovide a solutiontrack: #214