[Build][Bugfix] Fix build failed when GC_ENABLE_DNNL=ON #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huanghaixin008
requested review from
AndreyPavlenko and
kurapov-peter
and removed request for
AndreyPavlenko
dchigarev
reviewed
Aug 7, 2024
cmake/onednn.cmake
Outdated
Comment on lines
21
to
23
| set(GENERATOR_FLAG "-G ${CMAKE_GENERATOR}") | ||
| set(GENERATOR_FLAG "${CMAKE_GENERATOR}") | ||
| endif () | ||
| execute_process(COMMAND ${CMAKE_COMMAND} ${GENERATOR_FLAG} | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -G ${GENERATOR_FLAG} |
There was a problem hiding this comment.
what if CMAKE_GENERATOR is not defined? It seems that we'll get here an invalid command anyway:
cmake -G _empty_ -Wno-dev ...
There was a problem hiding this comment.
Fixed by adding an extra var for -G.
dchigarev
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
@huanghaixin008
Have you tested that it fixes the issue for you? Because for me building with -DGC_ENABLE_DNNL=ON works with and without your fix
kurapov-peter
approved these changes
Aug 7, 2024
@dchigarev Yes I did. Two other teammates and me cannot build on latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking #221