demo: rename clearlinux-demo-opae to opae-nlb-demo #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is blocked? |
kad
reviewed
Sep 5, 2019
scripts/set-version.sh
Outdated
There was a problem hiding this comment.
do you need to update here as well to opae-nlb-demo ?
mythi
changed the title
mythi
force-pushed
the
opae
branch
2 times, most recently
from
3ece090 to
ddcd514
Compare
opae-nlb-demo name is more descriptive about the content and becomes base image agnostic. Also, set ENTRYPOINT similar to what we did with other images and deployment files. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 70.79% 70.79%
=======================================
Files 16 16
Lines 1654 1654
=======================================
Hits 1171 1171
Misses 448 448
Partials 35 35Continue to review full report at Codecov.
|
kad
approved these changes
Sep 7, 2019
askervin
pushed a commit
to askervin/intel-device-plugins-for-kubernetes
that referenced
this pull request
May 6, 2020
rdt: construct schemata deterministically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opae-nlb name is more descriptive about the content and becomes
base image agnostic.
Also, set ENTRYPOINT similar to what we did with other images
and deployment files.
Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com