Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3 Sources and metadata adjustments #46

Merged
merged 3 commits into from
Aug 4, 2023
Merged

V1.3 Sources and metadata adjustments #46

merged 3 commits into from
Aug 4, 2023

Conversation

FredShallcrass
Copy link
Contributor

Changes to sources

This includes manual updates included in pull Request #27.

  • Updated font naming in sources
  • Updated licensing info as per Google fonts request in sources

Note: Hinting sources + otf, ttf, woff and woff2 font releases to follow.

@FredShallcrass FredShallcrass merged commit 90e667c into main Aug 4, 2023
@moyogo
Copy link

moyogo commented Aug 4, 2023

This reintroduces the glyph classes @deadMarks and @deadbelowMarks and the lookups DblMarks and CmbMarks using them to substitute spacing marks by non-spacing marks.

All spacing marks, no just /grave U+0060, must behave like spacing marks and remain spacing whether they follow a letter or not. Spacing marks characters should be used for spacing marks, non-spacing marks characters should be used for non-spacing marks. There should not be any substitution from spacing to non-spacing.

These two lookups and these glyph classes should be removed.

@@ -1,8 +1,8 @@
Copyright (c) 2023 Intel Corp. with Reserved Font Name "Intel One Mono", "IntelOne Mono"
Copyright 2023 Intel Corp. with Reserved Font Name 'Intel One Mono'
Copy link

@chrissimpkins chrissimpkins Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewTurrini @FredShallcrass Does Intel have a position on Dave's request to use "Intel" only in the reserved font name as documented in https://github.com/intel/intel-one-mono/pull/27/files#r1248099720?

Also, our (Google Fonts) approach is to use a different copyright string here: "Copyright 2023 The Intel One Mono Project Authors", then list the authors in the AUTHORS.txt file, as Rosalie proposed in #27. Will you please comment on whether this is an acceptable change for your team?

We're trying to resolve these issues to onboard the family into the Google Fonts catalog. Thank you!

cc @RosaWagner @davelab6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants