-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build documentation with meson #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It always re-generate the docs when running ninja even if I don't change any files. |
Instead of passing environment variables to the Doxygen process, Doxyfile will be autogenerated from Doxyfile.in template.
Since they are not handled by the install target
Instead of using conditional compilation for generarte documentation, this patch will block parsing Makefile in doc subdirectory if the documentation is not enabled. This patch will make compilation a bit faster when documentation is not generated.
Add to the clean target the removal of the generated documentation. Also use $(RM) for calling the command rm, which is a bit more portable.
Fixed |
xhaihao
approved these changes
Feb 1, 2018
oops! true! subdir-objects wasn't a good idea
Does that work for you? |
yes, it works without subdir-objects, please submit a pull request. thanks |
xhaihao
pushed a commit
that referenced
this pull request
Feb 2, 2018
There is an error below when running 'make distclean': Makefile:496: ../drm/.deps/va_drm_utils.Plo: No such file or directory make[2]: *** No rule to make target '../drm/.deps/va_drm_utils.Plo'. Stop. The regression is caused by f17486f which added subdir-objects to AM_INIT_AUTOMAKE. This patch comes from #172 (comment) Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com> Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
@ceyusa I pushed your patch |
taowan1
pushed a commit
to projectceladon/libva
that referenced
this pull request
Sep 4, 2019
There is an error below when running 'make distclean': Makefile:496: ../drm/.deps/va_drm_utils.Plo: No such file or directory make[2]: *** No rule to make target '../drm/.deps/va_drm_utils.Plo'. Stop. The regression is caused by f17486f which added subdir-objects to AM_INIT_AUTOMAKE. This patch comes from intel/libva#172 (comment) Change-Id: I933d8b066dbc5cfe3ea8f890003409d7396573e4 Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com> Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com> Signed-off-by: Romli, Khairul Anuar <khairul.anuar.romli@intel.com> Tracked-On: OAM-59281 Reviewed-on: 621493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims for building the documentation with meson.
In order to achieve it, it is required to move from using environment variables for passing Doxygen configuration, to the configuration template generation. In the case of autotools, sed is used.