va: fix the fd leak issue caused by vaInitialize failure #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Zhang <carl.zhang@intel.com>
evelikov
reviewed
Sep 18, 2023
| @@ -742,6 +742,11 @@ VAStatus vaInitialize( | |||
|
|
|||
| vaStatus = va_new_opendriver(dpy); | |||
|
|
|||
| if (VA_STATUS_SUCCESS != vaStatus) { | |||
| VADisplayContextP pDisplayContext = (VADisplayContextP)dpy; | |||
| pDisplayContext->vaDestroy(pDisplayContext); | |||
There was a problem hiding this comment.
I'm not sure this is a good idea for a few of reasons:
- on error we should not be touching out variables
- on error we're leaking the state setup via va_TraceInit - pre-existing issue
- as-is on vaInitialize() failure, state set in vaGetDisplay*() will be removed, which is fairly assummetrical and off IMHO
|
Instead, the display specifics should be moved from vaInitialize to vaGetDisplay* time, although that's not particularly clear and easy with the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741