va: Re-add drm_state and fd checks to VA_DRM_GetDriverNames #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XinfengZhang could you please merge this PR ? (Don't have permissions myself), thanks! :) |
Apps like gstreamer will crash on WSL without this check, which existed before but was removed in commit f097811 Signed-off-by: Sil Vilerino <sivileri@microsoft.com>
sivileri
force-pushed
the
add_drm_state_check
branch
from
3fa73fe
to
23bac67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adding
drm_statenull and checks toVA_DRM_GetDriverNames, apps like gstreamer will crash on WSL without this check, which existed before in VA_DRM_GetDriverName before but was removed in commitf09781156b24c571c187250f6d0f5eeff042528b.
After re-adding check gstreamer works fine again and checked vainfo/ffmpeg also work fine.
@dvrogozh @XinfengZhang could you please help review/merge ?