Fix Git URL parsing in get_protocol #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before fix: After fix: |
This was referenced Jul 4, 2025
|
thanks for the patch |
The get_protocol function incorrectly identified URLs containing ".git" anywhere in the string as Git repositories, causing errors when downloading raw files. This commit updates the regex to match ".git$" (end of string). Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
rli9
added a commit
that referenced
this pull request
Jul 9, 2025
Due to the change in 5abefe3, the protocol is not judged as git anymore, which results in ==> Retrieving sources... -> Source is https://github.com/axboe/fio.git#tag=fio-3.40 -> Downloading fio.git#tag=fio-3.40... ==> /tmp/stderr <== % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 162 100 162 0 0 152 0 0:00:01 0:00:01 --:--:-- 152 100 507k 0 507k 0 0 181k 0 --:--:-- 0:00:02 --:--:-- 658k The expected behavior is ==> Retrieving sources... -> Source is https://github.com/axboe/fio.git#tag=fio-3.38 -> Cloning fio git repo... Fixes: 5abefe3 ("Fix Git URL parsing in get_protocol (#520)") Signed-off-by: Philip Li <philip.li@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_protocol function incorrectly identified URLs containing ".git" anywhere in the string as Git repositories, causing errors when downloading raw files. This commit updates the regex to match ".git$" (end of string).