bin/run-local-monitor.sh: Avoid to include quote in rootfs variable #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://www.freedesktop.org/software/systemd/man/latest/os-release.html the format of /etc/os-release file is shell variable like to support sourced in a shell script. So, that is the best method to parse the file. While the original method may include quote in the result variable, for example, for $ cat /etc/os-release ... ID="mydist" ... we will get rootfs="mydist" with the original method, while we will get rootfs=mydist with shell source method. So, use the shell source method to avoid the issue. Signed-off-by: Huang Ying <ying.huang@linux.alibaba.com>
|
thanks for the patch |
alexshi
pushed a commit
to alexshi/lkp-tests
that referenced
this pull request
Aug 5, 2025
…ntel#524) From https://www.freedesktop.org/software/systemd/man/latest/os-release.html the format of /etc/os-release file is shell variable like to support sourced in a shell script. So, that is the best method to parse the file. While the original method may include quote in the result variable, for example, for $ cat /etc/os-release ... ID="mydist" ... we will get rootfs="mydist" with the original method, while we will get rootfs=mydist with shell source method. So, use the shell source method to avoid the issue. Signed-off-by: Huang Ying <ying.huang@linux.alibaba.com> Co-authored-by: Huang Ying <ying.huang@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
https://www.freedesktop.org/software/systemd/man/latest/os-release.html
the format of /etc/os-release file is shell variable like to support sourced in a shell script. So, that is the best method to parse the file.
While the original method may include quote in the result variable, for example, for
$ cat /etc/os-release
...
ID="mydist"
...
we will get rootfs="mydist" with the original method, while we will get rootfs=mydist with shell source method.
So, use the shell source method to avoid the issue.