[Test Framework] Add test scripts for getting started and setup #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangjian94cn
added a commit
to zhangjian94cn/llm-on-ray
that referenced
this pull request
Feb 4, 2024
…kflow (intel#84) * [pretrain] add megatron-deepspeed dependency * [pretrain] disable debug mode * [pretrain] update megatron-deepspeed gpu config * [pretrain] clear unnecessary file * [pretrain] add habana backend * [pretrain] clear useless files and update config * [pretrain] add megatron_deepspeed conf * [pretrain] fix pretrain_gpt import bug * [pretrain] fix pretrain_gpt import bug * [pretrain] update patch file * [pretrain] update dockerfile * [pretrain] update readme and config * [pretrain] Readme modify
|
github actions only provides ubuntu, I think we can leverage docker to prepare different images to simulate user env for getting started and setup. OS choices: ubuntu, rhel, suse |
Signed-off-by: Yizhong Zhang <zyzzxycj@163.com>
xwu99
reviewed
Mar 12, 2024
xwu99
reviewed
Mar 12, 2024
There was a problem hiding this comment.
no need to change this file.
There was a problem hiding this comment.
removed call-getting-started and added some needs
xwu99
reviewed
Mar 12, 2024
xwu99
reviewed
Mar 12, 2024
xwu99
reviewed
Mar 12, 2024
xwu99
reviewed
Mar 15, 2024
xwu99
reviewed
Mar 16, 2024
xwu99
reviewed
Mar 16, 2024
xwu99
reviewed
Mar 16, 2024
xwu99
reviewed
Mar 16, 2024
Signed-off-by: Xiaochang Wu <xiaochang.wu@intel.com>
Signed-off-by: Xiaochang Wu <xiaochang.wu@intel.com>
|
@Deegue thanks for your work! some minors need to be corrected. check above. |
|
Thanks @xwu99 , all comments above updated, waiting for CI. |
xwu99
reviewed
Mar 18, 2024
xwu99
reviewed
Mar 18, 2024
xwu99
reviewed
Mar 18, 2024
Signed-off-by: Xiaochang Wu <xiaochang.wu@intel.com>
xwu99
reviewed
Mar 18, 2024
Signed-off-by: Xiaochang Wu <xiaochang.wu@intel.com>
xwu99
approved these changes
Mar 18, 2024
|
approved. pls merge after CI passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
test_setup.shandtest_getting_started.shfor easy use and test.Maybe we can add these scripts to document since new users can deploy easily by this way.