Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Matrix] Add explicit cast for the conditional operator to avoid unexpected behavior #727

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[SYCL][Matrix] Add explicit cast for the conditional operator to avoid unexpected behavior #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions SYCL/Matrix/element_wise_all_ops_half.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,9 @@ template <typename T, size_t NUM_ROWS, size_t NUM_COLS> struct big_matrix {
};

template <typename T, size_t M, size_t N>
void assert_ops_ref(/*const T &C*/ accessor<T, 2, access::mode::read,
access::target::host_buffer>
C,
const float ref) {
void assert_ops_ref(
accessor<T, 2, access::mode::read, access::target::host_buffer> C,
const float ref) {
for (size_t i = 0; i < M; i++)
for (size_t j = 0; j < N; j++) {
auto diff = C[i][j] - ref;
Expand Down Expand Up @@ -204,7 +203,8 @@ void matrix_verify_logic(queue q, big_matrix<T, M, N> &A, nd_range<2> &r,
if (wi_slice_a[i]) {
if (wi_slice_a[i] > 2.0 || wi_slice_a[i] >= 2.0 ||
wi_slice_a[i] < 2.0 || wi_slice_a[i] <= 2.0) {
T val = (wi_slice_a[i] != 2.0) ? wi_slice_a[i] : 2.0;
T val = (wi_slice_a[i] != 2.0) ? wi_slice_a[i]
: static_cast<half>(2.0);
val--;
val++;
if (wi_slice_a[i] == 2.0) {
Expand Down