Skip to content

[Driver] Dump device code during SYCL offloading. #11132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 21, 2023

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Sep 9, 2023

This PR enables users to dump the device code generated during the SYCL compilation into a user provided directory.
The new option added is : -fsycl-dump-device-code=/path/to/directory/

Example usage:
If somebody runs : clang++ -fsycl -fsycl-dump-device-code=/path/to/directory test.cpp

the *.spv files generated during device compilation show up in /path/to/directory/

@srividya-sundaram srividya-sundaram changed the title [Driver] Dump device code. [Driver] Dump device code during SYCL offloading. Sep 11, 2023
@srividya-sundaram srividya-sundaram marked this pull request as ready for review September 11, 2023 17:14
@srividya-sundaram srividya-sundaram requested a review from a team as a code owner September 11, 2023 17:14
@srividya-sundaram srividya-sundaram temporarily deployed to WindowsCILock September 21, 2023 21:03 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to WindowsCILock October 18, 2023 23:32 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to WindowsCILock October 19, 2023 22:49 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to WindowsCILock November 1, 2023 05:33 — with GitHub Actions Inactive
@srividya-sundaram
Copy link
Contributor Author

srividya-sundaram commented Nov 20, 2023

@intel/llvm-gatekeepers Hello, this is ready for merge.
The SYCL Pre Commit on Windows / e2e / Intel GEN12 Graphics with Level Zero job has been in the "waiting" status
for several days even after re-starting the job multiple times.

Waiting for review: WindowsCILock needs approval to start deploying changes.

Any tip to get this job running?

@steffenlarsen
Copy link
Contributor

Hi @srividya-sundaram ! Due to CI issues we are currently manually letting windows jobs through. Restarting the jobs only places the runs behind the queue. Additionally, if you don't manually cancel your old processes they may get approved and eat resources, making the wait longer. We apologize for the inconvenience and will get to the runs related to this PR ASAP.

@hchilama
Copy link
Contributor

@intel/llvm-gatekeepers This is ready to merge.

@againull againull merged commit 96ce6ea into intel:sycl Nov 21, 2023
@srividya-sundaram
Copy link
Contributor Author

Hi @srividya-sundaram ! Due to CI issues we are currently manually letting windows jobs through. Restarting the jobs only places the runs behind the queue. Additionally, if you don't manually cancel your old processes they may get approved and eat resources, making the wait longer. We apologize for the inconvenience and will get to the runs related to this PR ASAP.

Thanks @steffenlarsen . I learnt about the Windows CI lock from Stewart offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants