[SYCL][Bindless][Exp] Allow read_image/mipmap to return user types
#11961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `read_image` and `read_mipmap` now allow user-defined types to be returned. - The `write_image` test case for user-defined types is updated to include both reading and writing of user-defined types. - An additional test is added for reading user-defined types where the image type is a mipmap. - The extension document has been updated to reflect the above changes. - The `write_image` function now checks whether a user-defined type was passed to it, and converts the input data accordingly. If the type passed has a specific NVPTX backend intrinsic, it will use that, otherwise it will write the user data type bit-cast to a variant of unsigned integer. - This patch marks the bump to revision `5.0` of the bindless images specification document.
isaacault
approved these changes
Nov 21, 2023
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
approved these changes
Nov 21, 2023
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
changed the title
read_image/mipmap to return user typesread_image/mipmap to return user types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_imageandread_mipmapnow allow user-defined types to be returned.The
write_imagetest case for user-defined types is updated to include both reading and writing of user-defined types.An additional test is added for reading user-defined types where the image type is a mipmap.
The extension document has been updated to reflect the above changes.
The
write_imagefunction now checks whether a user-defined type was passed to it, and converts the input data accordingly. If the type passed has a specific NVPTX backend intrinsic, it will use that, otherwise it will write the user data type bit-cast to a variant of unsigned integer.This patch marks the bump to revision
5.0of the bindless images specification document.