[SYCL][HIP] Add additional AMD GPU targets #12028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 27, 2023 10:46
…033, 1035, 1036, 1100, 1101, 1102, 1103, 1150, 1151, 1200, 1201
mdtoguchi
reviewed
Nov 28, 2023
| @@ -932,6 +947,7 @@ SmallString<64> SYCL::gen::getGenDeviceMacro(StringRef DeviceName) { | |||
| .Case("gfx906", "AMD_GPU_GFX906") | |||
| .Case("gfx908", "AMD_GPU_GFX908") | |||
| .Case("gfx90a", "AMD_GPU_GFX90A") | |||
| .Case("gfx90c", "AMD_GPU_GFX90C") | |||
There was a problem hiding this comment.
Missing macro additions?
gmlueck
reviewed
Nov 28, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
jinz2014
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
approved these changes
Nov 29, 2023
|
Tag @npmiller for awareness. |
npmiller
approved these changes
Nov 29, 2023
gmlueck
reviewed
Nov 29, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
gmlueck
reviewed
Nov 29, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
|
@mdtoguchi, could you please approve the pull request if it looks right ? Thanks. |
mdtoguchi
approved these changes
Dec 18, 2023
|
@jinz2014 Could you please merge the latest sycl branch and resolve conflicts. |
I applied the changes to the latest copy of the file. Is that okay ? Thanks. |
|
@againull I am confused by the conflict report though I applied the changes to the latest file. |
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
No worries, conflict seemed trivial to me so I resolved in the github web interface. I will merge if testing results are fine. |
jinz2014
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinz2014
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GFX targets are 909, 940, 941, 942, 1033, 1035, 1036, 1100, 1101, 1102, 1103, 1150, 1151, 1200, 1201.
Thanks for your reviews.