[SYCL][Doc] Use correct product name in extensions #12053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct name is "Intel(R) Data Center GPU Max Series".
Pennycook
reviewed
Dec 6, 2023
| @@ -65,7 +65,7 @@ new partitioning type | |||
| `info::partition_property::ext_intel_partition_by_cslice`. | |||
|
|
|||
| The only Intel GPU devices that currently support this type of partitioning | |||
| are the Data Center GPU Max series (aka PVC), and this support is only | |||
| are the Intel(R) Data Center GPU Max Series (aka PVC), and this support is only | |||
There was a problem hiding this comment.
Suggested change
| are the Intel(R) Data Center GPU Max Series (aka PVC), and this support is only | |
| are the Intel(R) Data Center GPU Max Series, and this support is only |
| @@ -181,7 +181,7 @@ other devices. | |||
| On many Intel devices, there is just one available queue index, and there is | |||
| therefore no advantage to using the `compute_index` property. However, this | |||
| property can sometimes be useful when running on Data Center GPU Flex series | |||
| devices (aka ATS-M) or Data Center GPU Max series devices (aka PVC). | |||
| devices (aka ATS-M) or Intel(R) Data Center GPU Max Series devices (aka PVC). | |||
There was a problem hiding this comment.
Suggested change
| devices (aka ATS-M) or Intel(R) Data Center GPU Max Series devices (aka PVC). | |
| devices or Intel(R) Data Center GPU Max Series devices. |
I have the impression that many people still know the hardware by its code name, though. In addition, we expose the code name in other places like the enumerator |
Pennycook
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct name is "Intel(R) Data Center GPU Max Series".