[SYCL][FPGA] Ignore duplicate memory attributes applied to declarations with different arguments #12175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns with different arguments
This patch refactors [[intel::fpga_memory]] to handle duplicate vs
conflicting attribute values properly and aligns with other upstream
attributes.
1. Adds diagnostic if there's a duplicate attribute with different
arguments already applied to the declaration.
2. No diagnostic is emitted if the arguments match.
3. Drops the duplicate attribute.
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
changed the title
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
clang/lib/Sema/SemaDeclAttr.cpp
Outdated
| @@ -7548,6 +7546,17 @@ static void handleSYCLIntelMemoryAttr(Sema &S, Decl *D, | |||
| if (MA->isImplicit()) | |||
| D->dropAttr<SYCLIntelMemoryAttr>(); | |||
|
|
|||
| // Check to see if there's a duplicate attribute with different values | |||
| // already applied to the declaration. | |||
| if (const auto *MA = D->getAttr<SYCLIntelMemoryAttr>()) { | |||
There was a problem hiding this comment.
Is there a reason we're making these changes? I mean I don't see the harm but did we have a request to diagnose this? Just curious about what prompted this change.
This check can also be combined with check above on L7545
There was a problem hiding this comment.
Is there a reason we're making these changes? I mean I don't see the harm but did we have a request to diagnose this? Just curious about what prompted this change.
@elizabethandrews, this is due to your comment #11385, so i thought to improve the existing duplicate memory attribute diagnostics as well.
There was a problem hiding this comment.
This check can also be combined with check above on L7545
Sure,
i will combine this
There was a problem hiding this comment.
This check can also be combined with check above on L7545
Done. Thanks for catching!
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
|
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
smanna12
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
approved these changes
Dec 21, 2023
elizabethandrews
approved these changes
Dec 21, 2023
|
Thank you @elizabethandrews and @premanandrao for reviews! @intel/llvm-gatekeepers, This PR is ready to be merged. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors [[intel::fpga_memory]] to handle duplicate vs conflicting attribute values properly and aligns with other upstream attributes.
1. Adds diagnostic if there's a duplicate attribute with different
arguments already applied to the declaration.
2. No diagnostic is emitted if the arguments match.
3. Drops the duplicate attribute.