Skip to content

[SYCL] Fix issues caught by static analyzer #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2023
Merged

[SYCL] Fix issues caught by static analyzer #12253

merged 2 commits into from
Dec 28, 2023

Conversation

againull
Copy link
Contributor

  • Don't throw exceptions in destructors (they are explicitely marked as noexcept)
  • Make sure that MPlatform data member of context_impl is always initialized.
  • Assign default value to MCacheMutex* in kernel_impl.

@againull
[SYCL] Fix issues caught by static analyzer
2839008 
* Don't throw exceptions in destructors (they are explicitely marked as
  noexcept)
* Make sure that MPlatform data member of context_impl is always
  initialized.
* Assign default value to MCacheMutex* in kernel_impl.
@againull againull requested a review from a team as a code owner December 27, 2023 21:07
@againull againull requested a review from bso-intel December 27, 2023 21:07
@againull againull merged commit c4f1cee into intel:sycl Dec 28, 2023
@againull againull deleted the static_analyzer_bugs branch April 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@againull @cperkinsintel