[SYCL] Move scheduler tests from LIT to Google unit tests #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2020 13:05
Rewrite device-agnostic tests using internal APIs as unit tests. Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
…ctor_tests * origin/sycl: (32 commits) [SYCL] Fix circular reference between events and queues (intel#1226) [CI][Doc] Use SSH to deploy GitHub Pages (intel#1232) [SYCL][CUDA][Test] Testing for use of CUDA primary context (intel#1174) [SYCL] allow underscore symbol in temporary directory name [SYCL] Reject zero length arrays (intel#1153) [SYCL] Fix static code analyzis concerns (intel#1189) [SYCL] Add more details about the -fintelfpga option (intel#1218) [SYCL][CUDA] Select only NVPTX64 device binaries (intel#1223) [SYCL] Reverse max work-group size order (intel#1177) [SYCL][Doc] Add GroupAlgorithms extension (intel#1079) [SYCL] Fix SYCL internal enumerators conflict with user defined macro (intel#1188) [SYCL][CUDA] Fixes context release and unnamed context scope (intel#1207) [SYCL][CUDA] Fix context creation property parsing [CUDA][PI] clang-format pi.h [SYCL][CUDA] Handle the case of not having any CUDA device (intel#1212) [SYCL] Fix check-sycl-deploy target problems (intel#1165) [SYCL] Disable tests which take more than 5 minutes (intel#1220) [SYCL] Make context constructors explicit to avoid unintended conversions (intel#1219) [SYCL][NFC] Add clang-format configuration file for SYCL LIT tests (intel#1224) [SYCL] Fix command cleanup invoked from multiple threads (intel#1214) ...
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
bader
reviewed
Mar 4, 2020
There was a problem hiding this comment.
"[SYCL] Avoid internal calls in scheduler LITs"
I think we should avoid testing runtime components in LIT test and use Google test framework for this.
I hope we can claim "[SYCL] Move scheduler tests from LIT to Google unit tests". Is this accurate summary?
Very good refactoring! Thanks!
alexbatashev
changed the title
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
bader
previously approved these changes
Mar 4, 2020
added 2 commits
March 5, 2020 10:48
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
…ctor_tests * origin/sycl: [SYCL] Fix device::get_devices() with a non-host device type (intel#1235) [SYCL][PI][CUDA] Implement kernel and kernel-group information queries (intel#1180) [SYCL] Remove default error code value in exception (intel#1150) [SYCL] Fix devicelib assert LIT test (intel#1245) [SYCL] Set aux-target-cpu for SYCL offload device compilation (intel#1225) [SYCL] Remove fabs and ceil from the list of unsupported math functions (intel#1217)
bader
approved these changes
Mar 5, 2020
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Oct 18, 2021
…> 64bits (intel#1246) In the LLVM IR if input is an integer with a width more than 64 bits the function will take this input through 'byval' pointer. If we leave the translation as is it will violate the extension spec, which says, that the input must by of an integer type. Add an extra load to fix this. Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com Original commit: KhronosGroup/SPIRV-LLVM-Translator@4f3641e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite device-agnostic tests using internal APIs as unit tests.
Signed-off-by: Alexander Batashev alexander.batashev@intel.com