[SYCL] Fix an assertion in graph processor #138
Conversation
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
| @@ -32,7 +32,6 @@ Scheduler::GraphProcessor::getWaitList(EventImplPtr Event) { | |||
|
|
|||
| void Scheduler::GraphProcessor::waitForEvent(EventImplPtr Event) { | |||
| Command *Cmd = getCommand(Event); | |||
| assert(!Cmd && "Event has no associated command?"); | |||
There was a problem hiding this comment.
Could you clarify in the commit message the reason why this assertion is erroneous, please?
Test case would be great too.
There was a problem hiding this comment.
It seems there is just a typo in assert condition:
Should be: assert(Cmd && "Event has no associated command?");
There was a problem hiding this comment.
Right, fixed.
There was a problem hiding this comment.
I think it doesn't make sense to write test on this because the problems reproduces on any test which submits commands with asserts enabled.
There was a problem hiding this comment.
I think it doesn't make sense to write test on this because the problems reproduces on any test which submits commands with asserts enabled.
Are you trying to say that this code is already covered by existing LIT tests?
There was a problem hiding this comment.
Are you trying to say that this code is already covered by existing LIT tests?
Yes, this assertion leads to about 30 LIT test failures in debug mode without this patch.
There was a problem hiding this comment.
When asserts are enabled*
sergey-semenov
changed the title
[vecz] Fix alignment of load operations
[vecz] Fix alignment of load operations
[vecz] Fix alignment of load operations
Signed-off-by: Sergey Semenov sergey.semenov@intel.com